Skip to content

data layer strucure ,test,and implementation#4

Closed
marwanqashwa wants to merge 18 commits intodevelopmentfrom
feature/data-handler
Closed

data layer strucure ,test,and implementation#4
marwanqashwa wants to merge 18 commits intodevelopmentfrom
feature/data-handler

Conversation

@marwanqashwa
Copy link
Contributor

@marwanqashwa marwanqashwa commented Apr 29, 2025 •
edited
Loading

data layer
add interface
-base schema to know how each entity transform to row or row to entity
-base data source
add class
-schema for each entity
-csv data source

@marwanqashwa marwanqashwa self-assigned this Apr 29, 2025
@github-actions
Copy link

github-actions bot commented Apr 29, 2025

Code Coverage Summary

There is no coverage information present for the Files changed

@marwanqashwa
Copy link
Contributor Author

marwanqashwa commented Apr 29, 2025

What do you think about testing each method in a class separately?
@mosayed01 @diyar214

@diyar214
Copy link
Contributor

diyar214 commented Apr 29, 2025

What do you think about testing each method in a class separately? @mosayed01 @diyar214

I think all the methods should be all in the same class because we are trying to test the CsvDataSource class, it's not practical to divide the methods of that class even if the CsvDataSourceTest.kt will have many lines of code.

diyar214
diyar214 previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@diyar214 diyar214 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marwanqashwa
Copy link
Contributor Author

marwanqashwa commented Apr 29, 2025

What do you think about testing each method in a class separately? @mosayed01 @diyar214

I think all the methods should be all in the same class because we are trying to test the CsvDataSource class, it's not practical to divide the methods of that class even if the CsvDataSourceTest.kt will have many lines of code.

ok I did that, but it was just a suggestion to avoid conflict in the class. however, it doesn't really seem logical.

mosayed01
mosayed01 requested changes Apr 29, 2025
View reviewed changes
@marwanqashwa marwanqashwa changed the title add generic interface base repository,generic csv data source data layer strucure ,test,and implementation Apr 30, 2025
@marwanqashwa marwanqashwa force-pushed the feature/data-handler branch from e13bbd9 to 295f104 Compare May 1, 2025 17:40
@marwanqashwa marwanqashwa marked this pull request as ready for review May 2, 2025 11:22
@marwanqashwa marwanqashwa deleted the feature/data-handler branch May 2, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosayed01 mosayed01 Awaiting requested review from mosayed01

@diyar214 diyar214 Awaiting requested review from diyar214

@Ahmed7osny1 Ahmed7osny1 Awaiting requested review from Ahmed7osny1

@AhmadKharfan AhmadKharfan Awaiting requested review from AhmadKharfan

Assignees

@marwanqashwa marwanqashwa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marwanqashwa @diyar214 @mosayed01